[Lldb-commits] [PATCH] D73116: [lldb/Initializers] Move all macOS initializers into PlatformMacOSX

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 21 12:30:44 PST 2020


Thanks, I was in meetings. Should be fixed

commit b6c62ef0871576dd03de2c0077ba15ad0be23f6b (HEAD -> master, origin/master)
Author: Jonas Devlieghere <jonas at devlieghere.com>
Date:   Tue Jan 21 12:25:45 2020 -0800

    [lldb/Platform] Re-add ifdef's to guard macOS-only code.

    I moved the code from the system initializer to PlatformMacOSX. The
    defines are still necessary because MacOSX is initialized on other
    platforms where the other platforms are not available.

On Tue, Jan 21, 2020 at 11:55 AM Stella Stamenova via Phabricator
<reviews at reviews.llvm.org> wrote:
>
> stella.stamenova added a comment.
>
> This change is causing a build break on Windows (which was hidden by the Hexagon build break you just fixed :().
>
> http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12857/steps/build/logs/stdio
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D73116/new/
>
> https://reviews.llvm.org/D73116
>
>
>


More information about the lldb-commits mailing list