[Lldb-commits] [PATCH] D73067: [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugins

Saleem Abdulrasool via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 20 16:18:31 PST 2020


compnerd added a comment.

Do we need to worry about ordering of the plugins?



================
Comment at: lldb/source/Plugins/Platform/CMakeLists.txt:9
   add_subdirectory(MacOSX)
-#elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
+elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
   add_subdirectory(Windows)
----------------
I would use `STREQUAL` rather than `MATCHES`.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73067/new/

https://reviews.llvm.org/D73067





More information about the lldb-commits mailing list