[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Let's give this a shot. I'm don't think this is fully right, but I also don't know how to improve that, exactly...



================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py:15
+
+    NO_DEBUG_INFO_TESTCASE = True
+    mydir = TestBase.compute_mydir(__file__)
----------------
Btw, all pexpect tests get this automatically from the base class.


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py:40-42
+        self.child.send("script print(foo)\n")
+        self.expect_prompt()
+        self.child.expect_exact("95126")
----------------
There's a ptrace version of `self.expect` to automate these things for you. It probably won't work for the multiline "breakpoint command add" command, but the rest could be something like `self.expect("script print(foo)", substrs=["95126"])`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72748/new/

https://reviews.llvm.org/D72748