[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

Wed Jan 15 01:14:28 PST 2020

labath added a comment.

In D72650#1820897 <https://reviews.llvm.org/D72650#1820897>, @paolosev wrote:

> In D72650#1819403 <https://reviews.llvm.org/D72650#1819403>, @labath wrote:
>
> > The patch looks pretty good. A reasonable way to test this would be again via `lldb-test object-file` . The command dumps the "unified section list" of the module, so if the debug info sections show up there, you know the symbol vendor has done it's job. You can look at `test/Shell/ObjectFile/ELF/build-id-case.yaml` for inspiration.
>
>
> Thank you for the suggestion! I added a test. 
>  I would have liked to use `llvm-objcopy --strip-all` in my test, but llvm-objcopy does not support wasm yet (I started <https://reviews.llvm.org/D71788> working on this feature but I found out that there was already an ongoing effort: https://reviews.llvm.org/D70930, and https://reviews.llvm.org/D70970) .
>  So I created with two separated yaml files.

That's fine. I think I actually prefer separate yaml representations, as that makes what goes into which file more explicit, and shields the test from changes in objcopy behavior. What you could consider is "inlining" the two yaml files into `unified-debug-sections.yaml`, and using the `yaml2obj --docnum` functionality (as in e.g., `test/Shell/Minidump/memory-region-from-module.yaml`) to create two wasm files.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72650/new/

https://reviews.llvm.org/D72650