[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

Tue Jan 14 16:02:28 PST 2020

paolosev added a comment.

In D72650#1819403 <https://reviews.llvm.org/D72650#1819403>, @labath wrote:

> The patch looks pretty good. A reasonable way to test this would be again via `lldb-test object-file` . The command dumps the "unified section list" of the module, so if the debug info sections show up there, you know the symbol vendor has done it's job. You can look at `test/Shell/ObjectFile/ELF/build-id-case.yaml` for inspiration.

Thank you for the suggestion! I added a test. 
I would have liked to use `llvm-objcopy --strip-all` in my test, but llvm-objcopy does not support wasm yet (I started <https://reviews.llvm.org/D71788> working on this feature but I found out that there was already an ongoing effort: https://reviews.llvm.org/D70930, and https://reviews.llvm.org/D70970) .
So I created with two separated yaml files.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72650/new/

https://reviews.llvm.org/D72650