[Lldb-commits] [PATCH] D72595: Fix lookup of symbols at the same address with no size vs. size

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked an inline comment as done.
jankratochvil added inline comments.


================
Comment at: lldb/source/Symbol/Symtab.cpp:898-900
+        if (i == num_entries - 1 ||
+            m_file_addr_to_index.GetMutableEntryAtIndex(i + 1)
+                    ->GetRangeBase() != curr_base_addr) {
----------------
clayborg wrote:
> So if we have N symbols for address 0x1000 with size of zero and we have one with a valid size, do we leave all symbols with zero size stay with a size of zero? I was confused by the comment and wanted to clarify.
Yes.  It sets size for at most one of the zero-sized symbols and it does that only in the case there is no sizeful symbol between them.
Maybe it should set all the zero-sized symbols in such case.
But that still would not help the arm32 regression as in that case there is one section-type zero-sized symbol and one sizeful regular symbol.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72595/new/

https://reviews.llvm.org/D72595