[Lldb-commits] [PATCH] D72513: Don't fail step out if remote server doesn't implement qMemoryRegionInfo

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 13 02:53:04 PST 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This seems fine to me, though I do get a feeling that without the testcase, some refactor will break this sooner or later. Making a test case for this would be tricky (though not impossible) and this it wasn't even your patch that broke this, so I don't think we should vehemently require a test to go with this. However, creating something might still be worthwhile, since you're the one who's going to have to debug any breakages...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72513/new/

https://reviews.llvm.org/D72513





More information about the lldb-commits mailing list