[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

Djordje Todorovic via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 13 00:25:10 PST 2020


djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:990
+    assert(PCAddr && "Missing return PC information for a call");
+    addLabelAddress(CallSiteDIE, dwarf::DW_AT_call_return_pc, PCAddr);
   }
----------------
Why don't we use the `getDwarf5OrGNUAttr()` for the `return_pc/low_pc`, since we use the address in both cases now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72489/new/

https://reviews.llvm.org/D72489





More information about the lldb-commits mailing list