[Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

[Jim Ingham via lldb-commits]

I think we should keep the pointer.  You can easily cast the pointer & call functions on it in the expression parser.  So if you have the log streaming as you are debugging and you see a log message that seems interesting, you can interrupt lldb and access the relevant context without having to find a variable pointing to it, or calling one of the lookup functions to find it.

Jim


> On Jan 8, 2020, at 5:01 PM, Greg Clayton via Phabricator via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> clayborg added a comment.
> 
> I don't mess with the expression parser all that much, but do we still want to see the pointer value in the log output?
> 
> current:
> 
>  CompleteTagDecl[2] on (ASTContext*)0x7ff31f01d240 Completing (TagDecl*)0x7ff31f01d568 named DeclName1
> 
> Should the new one be
> 
>  CompleteTagDecl[2] on scratch ASTContext. Completing (TagDecl*)0x7ff31f01d568 named Foo
> 
> Or include the pointer value **and** the name:
> 
>  CompleteTagDecl[2] on scratch (ASTContext*)0x7ff31f01d240. Completing (TagDecl*)0x7ff31f01d568 named DeclName1
> 
> Might be nice to still see the pointer value in case there are multiple ASTContexts with the same name?
> 
> 
> Repository:
>  rLLDB LLDB
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D72391/new/
> 
> https://reviews.llvm.org/D72391
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits