[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

[Pavel Labath via Phabricator via lldb-commits]

labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

The idea seems fine, but I think that the implementation needs more refinement, per the inline comments...



================
Comment at: packages/Python/lldbsuite/test/test_result.py:111-112
+        collecting values of ".categories" files. We start at the folder the test is in
+        and traverse the hierarchy upwards - we guarantee a .categories to exist
         at the top level directory so we do not end up looping endlessly.
         """
----------------
This part is no longer true, as we continue searching after finding the first file.


================
Comment at: packages/Python/lldbsuite/test/test_result.py:119
+        categories = set()
         while folder != '/':
             categories_file_name = os.path.join(folder, ".categories")
----------------
I don't think this will work on windows. I think we should stop iterating here as soon we reach the top level test folder (I don't know how to check that off-hand, but we should have that piece of information available somewhere.) That will also ensure we don't get confused by some spurious .categories file outside of the test tree.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71905/new/

https://reviews.llvm.org/D71905