[Lldb-commits] [PATCH] D71630: [lldb] Add a SubsystemRAII that takes care of calling Initialize and Terminate in the unit tests

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 19 07:52:10 PST 2019


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Yep, looks good.



================
Comment at: lldb/unittests/TestingSupport/SubsystemRAII.h:59
+  /// RAII for a single subsystem.
+  template <typename SubT> struct SubsystemRAIICase {
+
----------------
This doesn't have to be a template since it's already parameterized by the enclosing `T`. Or, you could actually move it outside the `SubsystemRAII` class (and possibly into a detail namespace) and save the compiler some work then Using the same class in different subsystem sequences.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71630/new/

https://reviews.llvm.org/D71630





More information about the lldb-commits mailing list