[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

[Michał Górny via Phabricator via lldb-commits]

mgorny requested changes to this revision.
mgorny added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:30
+  string(TOUPPER "${${variable}}" ${variable})
+  if ("${${variable}}" STREQUAL "OFF")
+    set(${variable} OFF PARENT_SCOPE)
----------------
Any reason not to use the regular `NOT` logic here? It would make it accept all kinds of false values just like you accept all kinds of true values below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71306/new/

https://reviews.llvm.org/D71306