[Lldb-commits] [PATCH] D71562: [lldb] Remove modern-type-lookup

[Gabor Marton via Phabricator via lldb-commits]

martong added a comment.

> I'm curious what you think should happen to the clang-import-test. We could either rewrite the tests as unit tests in the ASTImporterTest you guys are already using or we move the necessary parts of the ExternalASTMerger into the clang-import-test

Raphael, I think there is no point to keep the clang-import-test and the ExternalASTMerger in Clang if we remove the only user of these things.
So, in my opinion the best would be on a long-term if we could cover these tests with unit tests in ASTImporterTest.
On the other hand, I understand that rewriting these tests could be quite a work, so perhaps we should gradually add the new unit tests and once we are ready then we could remove entirely the clang-import-test and the ExternalASTMerger.
Also, some of the tests are already covered by the existing unit tests, e.g. `switch-stmt` with `ImportSwitch`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71562/new/

https://reviews.llvm.org/D71562