[Lldb-commits] [lldb] dcd1432 - [lldb-vscode] Centrally skip debug info variants for vscode tests
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Tue Dec 17 02:06:44 PST 2019
Author: Pavel Labath
Date: 2019-12-17T11:08:52+01:00
New Revision: dcd14324dced7d91aa8bf78a607055ca093b27bf
URL: https://github.com/llvm/llvm-project/commit/dcd14324dced7d91aa8bf78a607055ca093b27bf
DIFF: https://github.com/llvm/llvm-project/commit/dcd14324dced7d91aa8bf78a607055ca093b27bf.diff
LOG: [lldb-vscode] Centrally skip debug info variants for vscode tests
Previously each test was annotated manually. This does the same thing.
Added:
Modified:
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py
Removed:
################################################################################
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
index cb2ac355df53..835bd0b86ef2 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
@@ -46,7 +46,6 @@ def set_and_hit_breakpoint(self, continueToExit=True):
@skipIfWindows
@skipIfNetBSD # Hangs on NetBSD as well
- @no_debug_info_test
def test_by_pid(self):
'''
Tests attaching to a process by process ID.
@@ -62,7 +61,6 @@ def test_by_pid(self):
@skipIfWindows
@skipIfNetBSD # Hangs on NetBSD as well
- @no_debug_info_test
def test_by_name(self):
'''
Tests attaching to a process by process name.
@@ -101,7 +99,6 @@ def cleanup():
@skipUnlessDarwin
@skipIfDarwin
@skipIfNetBSD # Hangs on NetBSD as well
- @no_debug_info_test
def test_by_name_waitFor(self):
'''
Tests attaching to a process by process name and waiting for the
@@ -119,7 +116,6 @@ def test_by_name_waitFor(self):
@skipIfWindows
@skipIfDarwin
@skipIfNetBSD # Hangs on NetBSD as well
- @no_debug_info_test
def test_commands(self):
'''
Tests the "initCommands", "preRunCommands", "stopCommands",
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
index f5438b2e817c..8b13b9b161f2 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
@@ -17,7 +17,6 @@ class TestVSCode_setBreakpoints(lldbvscode_testcase.VSCodeTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
@skipIfWindows
- @no_debug_info_test
def test_set_and_clear(self):
'''Tests setting and clearing source file and line breakpoints.
This packet is a bit tricky on the debug adaptor side since there
@@ -149,7 +148,6 @@ def test_set_and_clear(self):
"expect breakpoint still verified")
@skipIfWindows
- @no_debug_info_test
def test_functionality(self):
'''Tests hitting breakpoints and the functionality of a single
breakpoint, like 'conditions' and 'hitCondition' settings.'''
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py
index 3e28b5782295..d20a3434188e 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py
@@ -18,7 +18,6 @@ class TestVSCode_setExceptionBreakpoints(
@skipIfWindows
@expectedFailureNetBSD
- @no_debug_info_test
def test_functionality(self):
'''Tests setting and clearing exception breakpoints.
This packet is a bit tricky on the debug adaptor side since there
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py
index 9a2c98d6332f..2c62bf80fcfb 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py
@@ -17,7 +17,6 @@ class TestVSCode_setFunctionBreakpoints(
mydir = TestBase.compute_mydir(__file__)
@skipIfWindows
- @no_debug_info_test
def test_set_and_clear(self):
'''Tests setting and clearing function breakpoints.
This packet is a bit tricky on the debug adaptor side since there
@@ -108,7 +107,6 @@ def test_set_and_clear(self):
"expect %u source breakpoints" % (len(functions)))
@skipIfWindows
- @no_debug_info_test
def test_functionality(self):
'''Tests hitting breakpoints and the functionality of a single
breakpoint, like 'conditions' and 'hitCondition' settings.'''
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py
index 93110019055b..d1d92346e436 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py
@@ -24,7 +24,6 @@ def verify_completions(self, actual_list, expected_list, not_expected_list=[]):
@skipIfWindows
@skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots
- @no_debug_info_test
def test_completions(self):
"""
Tests the completion request at
diff erent breakpoints
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py
index 0e35544fc561..76c806426c0f 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py
@@ -18,7 +18,6 @@ class TestVSCode_launch(lldbvscode_testcase.VSCodeTestCaseBase):
@skipIfWindows
@skipIfDarwin # Flaky
- @no_debug_info_test
def test_default(self):
'''
Tests the default launch of a simple program. No arguments,
@@ -36,7 +35,6 @@ def test_default(self):
"make sure program path is in first argument")
@skipIfWindows
- @no_debug_info_test
def test_stopOnEntry(self):
'''
Tests the default launch of a simple program that stops at the
@@ -56,7 +54,6 @@ def test_stopOnEntry(self):
'verify stop isn\'t "main" breakpoint')
@skipIfWindows
- @no_debug_info_test
def test_cwd(self):
'''
Tests the default launch of a simple program with a current working
@@ -84,7 +81,6 @@ def test_cwd(self):
self.assertTrue(found, "verified program working directory")
@skipIfWindows
- @no_debug_info_test
def test_debuggerRoot(self):
'''
Tests the "debuggerRoot" will change the working directory of
@@ -113,7 +109,6 @@ def test_debuggerRoot(self):
self.continue_to_exit()
@skipIfWindows
- @no_debug_info_test
def test_sourcePath(self):
'''
Tests the "sourcePath" will set the target.source-map.
@@ -139,7 +134,6 @@ def test_sourcePath(self):
self.continue_to_exit()
@skipIfWindows
- @no_debug_info_test
def test_disableSTDIO(self):
'''
Tests the default launch of a simple program with STDIO disabled.
@@ -156,7 +150,6 @@ def test_disableSTDIO(self):
@skipIfWindows
@skipIfLinux # shell argument expansion doesn't seem to work on Linux
@expectedFailureNetBSD
- @no_debug_info_test
def test_shellExpandArguments_enabled(self):
'''
Tests the default launch of a simple program with shell expansion
@@ -180,7 +173,6 @@ def test_shellExpandArguments_enabled(self):
glob, program))
@skipIfWindows
- @no_debug_info_test
def test_shellExpandArguments_disabled(self):
'''
Tests the default launch of a simple program with shell expansion
@@ -206,7 +198,6 @@ def test_shellExpandArguments_disabled(self):
glob, glob))
@skipIfWindows
- @no_debug_info_test
def test_args(self):
'''
Tests launch of a simple program with arguments
@@ -232,7 +223,6 @@ def test_args(self):
'arg[%i] "%s" not in "%s"' % (i+1, quoted_arg, lines[i]))
@skipIfWindows
- @no_debug_info_test
def test_environment(self):
'''
Tests launch of a simple program with environment variables
@@ -265,7 +255,6 @@ def test_environment(self):
var, lines))
@skipIfWindows
- @no_debug_info_test
def test_commands(self):
'''
Tests the "initCommands", "preRunCommands", "stopCommands" and
@@ -332,7 +321,6 @@ def test_commands(self):
self.verify_commands('exitCommands', output, exitCommands)
@skipIfWindows
- @no_debug_info_test
def test_extra_launch_commands(self):
'''
Tests the "luanchCommands" with extra launching settings
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
index 22a384119744..199b80c8f6fa 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
@@ -6,6 +6,8 @@
class VSCodeTestCaseBase(TestBase):
+ NO_DEBUG_INFO_TESTCASE = True
+
def create_debug_adaptor(self):
'''Create the Visual Studio Code debug adaptor'''
self.assertTrue(os.path.exists(self.lldbVSCodeExec),
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py
index 681a6b013e52..817e40ecbf6b 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py
@@ -52,7 +52,6 @@ def verify_stackFrame(self, frame_idx, stackFrame):
expected_line))
@skipIfWindows
- @no_debug_info_test
def test_stackTrace(self):
'''
Tests the 'stackTrace' packet and all its variants.
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py
index 5c6ee0c5e68c..2431464f8c8e 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/step/TestVSCode_step.py
@@ -16,7 +16,6 @@ class TestVSCode_step(lldbvscode_testcase.VSCodeTestCaseBase):
mydir = TestBase.compute_mydir(__file__)
@skipIfWindows
- @no_debug_info_test
def test_step(self):
'''
Tests the stepping in/out/over in threads.
diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py
index 770d58dc7159..55c4fd000b2f 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py
@@ -74,7 +74,6 @@ def verify_variables(self, verify_dict, variables, varref_dict=None):
self.verify_values(verify_dict[name], variable, varref_dict)
@skipIfWindows
- @no_debug_info_test
def test_scopes_variables_setVariable_evaluate(self):
'''
Tests the "scopes", "variables", "setVariable", and "evaluate"
More information about the lldb-commits
mailing list