[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 16 17:49:36 PST 2019


jingham updated this revision to Diff 234206.
jingham added a comment.

Changed the test case from locking.c - using pthreads directly - to locking.cpp using std::thread & Co.

I also changed the test I cobbed this one from to use std::thread as well.  I prospectively removed the expected fail Windows from the expression test, since this should build now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71440/new/

https://reviews.llvm.org/D71440

Files:
  lldb/include/lldb/Core/Disassembler.h
  lldb/include/lldb/Target/ThreadPlanStepRange.h
  lldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/Makefile
  lldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/TestExprDoesntBlock.py
  lldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/locking.c
  lldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/locking.cpp
  lldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/Makefile
  lldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/TestStepOverDoesntBlock.py
  lldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/locking.cpp
  lldb/source/Core/Disassembler.cpp
  lldb/source/Target/Process.cpp
  lldb/source/Target/ThreadPlanStepRange.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71440.234206.patch
Type: text/x-patch
Size: 16814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191217/49142aaf/attachment.bin>


More information about the lldb-commits mailing list