[Lldb-commits] [PATCH] D71377: [lldb/CMake] Rename LLDB_DISABLE_CURSES to LLDB_ENABLE_CURSES

Thu Dec 12 02:25:29 PST 2019

labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.

================
Comment at: lldb/docs/resources/build.rst:406
   -DLLDB_DISABLE_PYTHON=1
+  -DLLDB_ENABLE_CURSES=1
   -DLLVM_ENABLE_TERMINFO=0
----------------
`=0` also

================
Comment at: lldb/source/API/SBDebugger.cpp:686-690
+#ifdef LLDB_ENABLE_CURSES
+  bool have_curses = false;
+#else
   bool have_curses = true;
 #endif
----------------
this reminded me that it might be better to use `#cmakedefine01` in Config.h, as then this could just be `AddBoolConfigEntry(..., LLDB_ENABLE_CURSES);`. The `01` version is also used in llvm, though not very consistently..

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71377/new/

https://reviews.llvm.org/D71377