[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

Please do print out the return address in the log.  That will be helpful.

The LLDB_LOG* macros check the log for you.  They are convenient if the thing you are going to log happen in one step.  If you need to do some more logic when gathering up the log message and don't want to stuff it all in the arguments to the macro, you can use "if (log)..."  Also the LLDB_LOG* macros were added fairly recently so there may be some places that haven't been converted to use them.

@clayborg: do you know under what circumstances we won't be able to find the permissions for an address?  This patch would reject setting the breakpoint in that situation, so I'd like to be clear when that would happen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71372/new/

https://reviews.llvm.org/D71372