[Lldb-commits] [PATCH] D71212: [lldb] Centralize type "desugaring" logic in ClangASTContext

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

I think this can be further simplified, but we can also do the move to `QualType::getDesugaredType` in a follow-up commit to unblock your atomic struct patch.



================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:2489
+    case clang::Type::Typedef:
+      type = cast<clang::TypedefType>(type)->getDecl()->getUnderlyingType();
+      break;
----------------
QualType already has a `getDesugaredType` implementation that does the same (but handles more cases, so you still need the switch statement but you can unify all the case bodies if you want to keep this NFC).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71212/new/

https://reviews.llvm.org/D71212