[Lldb-commits] [PATCH] D71052: [lldb][NFC] Move Address and AddressRange functions out of Stream and let them take raw_ostream

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 5 03:43:43 PST 2019


teemperor marked 2 inline comments as done.
teemperor added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/commands/expression/import-std-module/vector-basic/TestBasicVector.py:23-53
-        self.expect("expr (size_t)a.size()", substrs=['(size_t) $0 = 3'])
-        self.expect("expr (int)a.front()", substrs=['(int) $1 = 3'])
-        self.expect("expr (int)a[1]", substrs=['(int) $2 = 1'])
-        self.expect("expr (int)a.back()", substrs=['(int) $3 = 2'])
+        self.expect("expr a.size()", substrs=[' $0 = 3'])
+        self.expect("expr a.front()", substrs=[' $1 = 3'])
+        self.expect("expr a[1]", substrs=[' $2 = 1'])
+        self.expect("expr a.back()", substrs=[' $3 = 2'])
 
         self.expect("expr std::sort(a.begin(), a.end())")
-        self.expect("expr (int)a.front()", substrs=['(int) $4 = 1'])
----------------
labath wrote:
> huh ?
Just checking if you actually look at my patches :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71052/new/

https://reviews.llvm.org/D71052





More information about the lldb-commits mailing list