[Lldb-commits] [PATCH] D70946: [lldb][NFC] Move Curses interface implementation to own file

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked 2 inline comments as done.
teemperor added inline comments.


================
Comment at: lldb/include/lldb/Core/CursesInterface.h:38-51
+class IOHandlerCursesValueObjectList : public IOHandler {
+public:
+  IOHandlerCursesValueObjectList(Debugger &debugger,
+                                 ValueObjectList &valobj_list);
+
+  ~IOHandlerCursesValueObjectList() override;
+
----------------
labath wrote:
> Is this class actually used anywhere? Can we delete it and rename this file to a plain `IOHandlerCursesGUI.h` ?
Interesting, this is indeed not referenced anywhere. Will remove it and then rename the file. Thanks!


================
Comment at: lldb/source/Commands/CommandObjectGUI.cpp:14
 #include "lldb/lldb-private.h"
 
+#include "lldb/Core/CursesInterface.h"
----------------
labath wrote:
> What's up with these random blank lines? It seems everyone is adding them based on some different key... llvm does not use blank lines at all and just relies on clang-format to produce a "reasonable" include block.
I'm getting paid by LOC


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70946/new/

https://reviews.llvm.org/D70946