[Lldb-commits] [PATCH] D70946: [lldb][NFC] Move Curses interface implementation to own file

[Raphael Isemann via Phabricator via lldb-commits]

teemperor created this revision.
teemperor added reviewers: labath, clayborg, JDevlieghere.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.

The IOHandler class source file is currently around 4600 LOC. However only 200
of these lines are concerned with the actual IOHandler class and the rest are the
implementations for Editline, IOHandlerConfirm and the Curses interface. All these
large features also cause that the IOHandler (which is in Core) has a large set of dependencies
on other parts of LLDB.

This patch splits out the code for the curses interface into its own file. This way
the simple IOHandler code is no longer buried in-between much larger functionalities.

Next up is splitting out the other IOHandlers into their own files and then move them
to more appropriate parts of LLDB.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D70946

Files:
  lldb/include/lldb/Core/CursesInterface.h
  lldb/include/lldb/Core/IOHandler.h
  lldb/source/Commands/CommandObjectGUI.cpp
  lldb/source/Core/CMakeLists.txt
  lldb/source/Core/CursesInterface.cpp
  lldb/source/Core/IOHandler.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70946.231838.patch
Type: text/x-patch
Size: 270067 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191203/4050ea44/attachment-0001.bin>