[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

Mon Dec 2 16:21:06 PST 2019

shafik added a comment.

In D70846#1763731 <https://reviews.llvm.org/D70846#1763731>, @labath wrote:

> There's `lldb-shell :: SymbolFile/DWARF/find-basic-function.cpp`, which probably didn't get run for you as you didn't have lld enabled (cmake -DLLVM_ENABLE_PROJECTS=...;lld). You'll need to update that test to match the new behavior, but other than that, I think this is a good change.

So with this change for the `find-basic-function.cpp` test I no longer see any results for the `full` case so we should at least generate a case that has results for the `full` case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70846/new/

https://reviews.llvm.org/D70846