[Lldb-commits] [PATCH] D70907: Change Target::FindBreakpointsByName to use a vector

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Dec 2 14:44:09 PST 2019


jingham added a comment.

In other places, I've used  "XList" to mean the container that manages the things contained, and "XCollection" to be a random possibly unrelated collection of items.  It doesn't make any sense to have a collection of breakpoints from more than one target, so the collection class could ensure that, whereas a std::vector is just a random assortment.  But I'm not sure that adds enough value to warrant adding a collection container here.  std::vector is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70907/new/

https://reviews.llvm.org/D70907





More information about the lldb-commits mailing list