[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added a comment.

In D70840#1763705 <https://reviews.llvm.org/D70840#1763705>, @mstorsjo wrote:

> In D70840#1763639 <https://reviews.llvm.org/D70840#1763639>, @labath wrote:
>
> > Yeah, this is going to be tricky... I don't really know what's the right way to do this, but here are the thoughts I have on this so far:
> >
> > - The new DWARFDebugInfoEntry member is going to substantially increase our memory footprint -- that's a non-starter
>
>
> Ok, I feared that class was one where the size is critical yeah...
>
> > - I don't like the inconsistency where all addresses are demangled in the DWARF code, except the line tables, which are in the "generic" code
>
> Yup. The reason for doing it like this was as I tried to find the most narrow interface where I could catch all of them.


Is there any corresponding place in generic code where one could do the same operation on the addresses that comes from pc_lo/pc_hi ranges from .debug_info and .debug_aranges (not familiar with this section and when it's generated etc), if that would end up touching fewer places? The existing predecent in DWARFCallFrameInfo::GetFDEIndex is dwarf specific, but in generic code outside of the dwarf symbolfile plugin.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70840/new/

https://reviews.llvm.org/D70840