[Lldb-commits] [PATCH] D70100: [DWARF] Handle call sites with indirect call targets

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 21 13:08:07 PST 2019


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/include/lldb/Symbol/Function.h:453
   /// PC addresses (in increasing order).
-  llvm::MutableArrayRef<CallEdge> GetCallEdges();
+  llvm::ArrayRef<std::unique_ptr<CallEdge>> GetCallEdges();
 
----------------
Since DWARFExpression has a copy constructer, perhaps we should get rid of the unique_ptr to make it faster to allocate/deconstruct?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70100/new/

https://reviews.llvm.org/D70100





More information about the lldb-commits mailing list