[Lldb-commits] [PATCH] D70324: [lldb][test] Prevent \n in calls to lldb's expect() test helper.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 18 01:06:57 PST 2019


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Thanks for getting to the bottom of this. Adding the \n check is fine. The "expect" function was meant to be an pexpect equivalent of the "expect" function in regular tests (which also just handles a single command). If anyone is doing something fancier than that, he should probably interact with pexpect directly.



================
Comment at: lldb/packages/Python/lldbsuite/test/terminal/TestEditline.py:29-33
         3. Send "c"         -> "el c[]ommand"
         4. Ctrl+left twice  -> "[]el command"
         5. Send "h"         -> "h[]el command"
         6. Ctrl+right       -> "hel[] command"
         7. Send "p"         -> "help command"
----------------
Maybe update the example to use the command "print" too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70324/new/

https://reviews.llvm.org/D70324





More information about the lldb-commits mailing list