[Lldb-commits] [PATCH] D70294: [lldb][NFC] Pass a ValueObject to DumpTypeValue instead of bitfield size/offset pair

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 15 01:18:40 PST 2019


teemperor created this revision.
teemperor added a reviewer: labath.
teemperor added a project: Upstreaming LLDB's downstream patches.
Herald added subscribers: lldb-commits, JDevlieghere, abidh.
Herald added a project: LLDB.
teemperor retitled this revision from "[lldb] Pass a ValueObject to DumpTypeValue instead of bitfield size/offset pair" to "[lldb][NFC] Pass a ValueObject to DumpTypeValue instead of bitfield size/offset pair".

This makes calling DumpTypeValue less tricky as it's not possible to mix up the size/offset
parameters. Also allows us to drop downstream swift patches that try to pass even more
ValueObject members as separate parameters to this function.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D70294

Files:
  lldb/include/lldb/Symbol/ClangASTContext.h
  lldb/include/lldb/Symbol/CompilerType.h
  lldb/include/lldb/Symbol/TypeSystem.h
  lldb/source/DataFormatters/TypeFormat.cpp
  lldb/source/Symbol/ClangASTContext.cpp
  lldb/source/Symbol/CompilerType.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70294.229463.patch
Type: text/x-patch
Size: 9336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191115/90459a29/attachment.bin>


More information about the lldb-commits mailing list