[Lldb-commits] [PATCH] D70215: Use ForEachExternalModule in ParseTypeFromClangModule (NFC)

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM minus some small changes.



================
Comment at: lldb/include/lldb/Symbol/SymbolFile.h:127
+  /// Apply a lambda to each external lldb::Module referenced by this
+  /// compilation unit. Recursively also descends into the referenced external
+  /// modules of any encountered compilation unit.
----------------
"this compilation unit", that doesn't really fit to the SymbolFile class. Maybe we could just do like `@see CompileUnit::ForEachExternalModule`?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2511
       // list.
+
       types.InsertUnique(matching_type->shared_from_this());
----------------
unrelated whitespace change?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70215/new/

https://reviews.llvm.org/D70215