[Lldb-commits] [PATCH] D70134: dotest: Add a way for the run_to_* helpers to register dylibs

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

In D70134#1743075 <https://reviews.llvm.org/D70134#1743075>, @clayborg wrote:

> In D70134#1742647 <https://reviews.llvm.org/D70134#1742647>, @jingham wrote:
>
> > This is fine.
> >
> > I wondered a bit about whether it would be generally useful to add the 'dylibs that have to be copied' to the SBLaunchInfo?  It has some other platform'y like things.  I'm not strongly promoting the idea, just thought I'd float it.
>
>
> You can currently do this by setting the platform file spec for a SBModule. If that is set, then the target will upload the module to that path. The main executable always goes to the remote working directory if its platform file spec isn't set, but any module can set this manually. The register shared libraries code sets the platform path.


I don't think that this would help in Fred's case, since he needs to pass something that will work to the API that CREATES the target, so he doesn't really have an SBModule for the library yet.  OTOH, since there's another way to do this that works more generally, then that make adding it to the SBLaunchInfo seem redundant...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70134/new/

https://reviews.llvm.org/D70134