[Lldb-commits] [PATCH] D69704: [lldb] Add IsDebugInfoCompatible method to SBModule to allow checking compatibility between language versions

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested review of this revision.
teemperor marked an inline comment as done.
teemperor added a comment.

Marking this as changes needed that I don't land this without applying Pavel's comment.



================
Comment at: lldb/source/API/SBModule.cpp:700-704
+  if (!type_system_or_err) {
+    sb_error.SetErrorStringWithFormat(
+        "no type system for language %s",
+        Language::GetNameForLanguageType(language));
+    llvm::consumeError(type_system_or_err.takeError());
----------------
labath wrote:
> labath wrote:
> > Do you want to store the actual error message in `type_system_or_err` into sb_error?
> Actually, you can do that by just saying `sb_error.ref() = type_system_or_err.takeError()` or something along those lines. :)
Oh, TIL!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69704/new/

https://reviews.llvm.org/D69704