[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 12 11:23:38 PST 2019


jingham added a comment.

It looks like all the continue routines in lldbvscode_testcase.py use self.vscode.wait_for_stopped() after setting the target going.  Would that fix the problem here?  Without knowing anything about the protocol VSCode is using, I can't say that's right.  But if launch is asynchronous, as it looks like it is, it seems reasonable to test whether wait_for_stopped() also works for launch.  Be weird if it didn't...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70127/new/

https://reviews.llvm.org/D70127





More information about the lldb-commits mailing list