[Lldb-commits] [PATCH] D70134: dotest: Add a way for the run_to_* helpers to register dylibs

[Frederic Riss via Phabricator via lldb-commits]

friss created this revision.
friss added a reviewer: jingham.
Herald added a project: LLDB.

To run the testsuite remotely the executable needs to be uploaded to
the target system. The Target takes care of this by default.

When the test uses additional shared libraries, those won't be handled
by default and need to be registered with the target using
test.registerSharedLibrariesWithTarget(target, dylib).

Calling this API requires a target, so it doesn't mesh well with the
run_to_* helpers that we've been advertising as the right way to write
tests.

This patch adds an extra_images argument to all the helpers and does
the registration automatically when running a remote
testsuite. TestWeakSymbols.py was converted to use this new scheme.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70134

Files:
  lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py
  lldb/packages/Python/lldbsuite/test/lldbutil.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70134.228916.patch
Type: text/x-patch
Size: 5799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191112/b4e3f372/attachment-0001.bin>