[Lldb-commits] [PATCH] D70022: [lldb] [Process/NetBSD] Improve threading support

[Michał Górny via Phabricator via lldb-commits]

mgorny marked 2 inline comments as done.
mgorny added a comment.

Well, are there any LLDB commands that can actually cause such an event to happen? I haven't been able to find one to send a signal to thread in the first place.



================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:454-455
+    case eStateStopped:
+      if (action->signal != LLDB_INVALID_SIGNAL_NUMBER)
+        return Status("Passing signal to suspended thread unsupported");
+
----------------
labath wrote:
> Maybe this could be an assert ?
Well, looking at the gdb protocol, it probably can't happen indeed. However, when I was writing that I assumed 'ResumeActionList is the limit', and didn't want to assert-crash if things were extended in the future.


================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:477-481
+    signal = siginfo->psi_siginfo.si_signo;
+  }
+
+  ret = PtraceWrapper(PT_CONTINUE, GetID(), reinterpret_cast<void *>(1),
+                      signal);
----------------
labath wrote:
> (just curious) so you need to pass the signal both in the siginfo struct, and also to the PT_CONTINUE operation?
Yes. The former is not strictly necessary but the latter is obligatory.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70022/new/

https://reviews.llvm.org/D70022