[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

[Jason Molenda via lldb-commits]

<signaturebeforequotedtext></signaturebeforequotedtext>
On 11/09/19 12:41 PM, Jan Kratochvil  <jan.kratochvil at redhat.com> wrote: 
> 
> On Sat, 09 Nov 2019 03:25:51 +0100, Jason Molenda via lldb-commits wrote:
> > I'm switching the default for at least the weekend via 60ab30ebce833c87bd4776f67cd9a82fe162ef9c / https://reviews.llvm.org/rG60ab30ebce83 so the bots aren't failing because of this, we can all look into this next week. I think the best solution is to get lldb to fall back to p/P if g/G are not supported (which we need to talk to some targets), and disable debugserver's g/G packet support until I can debug where the bug is over there.
> > 
> > I'm still concerned about some of the macos CI bots which use the installed debugservers, which will continue to have this g/G bug for a while, we'll figure all that out next week.
> 
> Linux Fedora 30 x86_64:
> d162e02cee74a3dbbfb1317fa9749f5e18610282
> 
>  File "/home/jkratoch/redhat/llvm-monorepo/lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoGPacketSupported.py", line 93, in test
>  self.assertEqual(rax, 0xffffffe03c778278)
> AssertionError: 0 != 18446743937285063288L
> 



Hi Jan, thanks for letting me know. Would it be possible to run the test case with tracing enabled? On my mac I use the lldb-dotest command, like

./lldb-dotest -t -v -p TestNoGPacketSupported.py

I wrote the test case so it will print all of the packets when trace mode is enabled, I can probably tell what's going on from that.



I'm surprised there's a difference of behavior here, maybe I made a mistake when I changed the default Friday evening. This is lldb talking to a fake gdb RSP stub replaying packets - it shouldn't matter if lldb itself is running on a mac or on a linux system, unless I'm forgetting something.

Thanks!
<signatureafterquotedtext></signatureafterquotedtext>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191110/5c60143e/attachment-0001.html>