[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

[Jason Molenda via lldb-commits]

A heads-up - lldb is failing to detect the case where the remote gdb RSP stub does not support the 'g' packet.  I found this while doing some bare board debugging; g fails and doesn't fall back to fetching register values individually.  

I wrote a test TestNoGPacketSupported.py to show this behavior - it's currently marked as @expectedFailureAll.  If I add the plugin.process.gdb-remote.use-g-packet-for-reading = false setting, the test case passes, but of course we can't require people to use that.  lldb has to be adaptive to the packets that the remote stub supports.


I'll try to look at the updating the changes to work correctly in this environment, but I wanted to raise the issue more widely in case anyone has a chance before me. 


J
 

> On Oct 30, 2019, at 9:30 AM, Guilherme Andrade via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> guiandrade added a comment.
> 
> In D62931#1726865 <https://reviews.llvm.org/D62931#1726865>, @labath wrote:
> 
>> This looks fine to me. Thanks for your patience. Do you still need someone to commit this for you?
> 
> 
> Np. Yes, I do. Could you please do it for me?
> 
> Thanks!
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D62931/new/
> 
> https://reviews.llvm.org/D62931
> 
> 
>