[Lldb-commits] [PATCH] D69846: [lldb] [Python] Build readline override module only on Linux

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 5 07:32:58 PST 2019


mgorny created this revision.
mgorny added reviewers: serge-sans-paille, labath, JDevlieghere, krytarowski.

Restrict building the readline override to Linux only.  It both does not
build on *BSD systems, and is largely irrelevant since they default to
using libedit over readline anyway.  This restores the behavior
of the old readline override that also was built only on Linux.


https://reviews.llvm.org/D69846

Files:
  lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h


Index: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h
===================================================================
--- lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h
+++ lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h
@@ -9,7 +9,7 @@
 #ifndef LLDB_PLUGINS_SCRIPTINTERPRETER_PYTHON_PYTHONREADLINE_H
 #define LLDB_PLUGINS_SCRIPTINTERPRETER_PYTHON_PYTHONREADLINE_H
 
-#if !defined(LLDB_DISABLE_LIBEDIT) && !defined(__APPLE__)
+#if !defined(LLDB_DISABLE_LIBEDIT) && defined(__linux__)
 // NOTE: Since Python may define some pre-processor definitions which affect the
 // standard headers on some systems, you must include Python.h before any
 // standard headers are included.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69846.227874.patch
Type: text/x-patch
Size: 724 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191105/e18cb558/attachment.bin>


More information about the lldb-commits mailing list