[Lldb-commits] [PATCH] D69793: Bundle libedit-compatible readline replacement

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 5 06:37:52 PST 2019


mgorny added a comment.

Ok, this is breaking build on NetBSD:

http://lab.llvm.org:8014/builders/netbsd-amd64/builds/92/steps/ninja%20build%20local/logs/stdio

Header location is not the only problem, the code fails to build after fixing that.

FWICS, the previous module was built only for subset of systems:

  -# build the Python readline suppression module only on Linux
  -if("${CMAKE_SYSTEM_NAME}" MATCHES "Linux" OR "${CMAKE_SYSTEM_NAME}" STREQUAL "GNU" OR "${CMAKE_SYSTEM_NAME}" STREQUAL "kFreeBSD")
  -   add_subdirectory(readline)
  -endif()

I suppose the new one needs to be adjusted accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69793/new/

https://reviews.llvm.org/D69793





More information about the lldb-commits mailing list