[Lldb-commits] [PATCH] D67793: new api class: SBFile

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 22 12:49:09 PDT 2019


mgorny added a comment.

While looking at the other bug, I noticed something suspicious here.



================
Comment at: lldb/trunk/source/Host/common/File.cpp:74
+      .Case("r", File::eOpenOptionRead)
+      .Case("w", File::eOpenOptionWrite)
+      .Case("a", File::eOpenOptionWrite | File::eOpenOptionAppend |
----------------
Shouldn't this also include `File::eOpenOptionCanCreate | File::eOpenOptionTruncate`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67793/new/

https://reviews.llvm.org/D67793





More information about the lldb-commits mailing list