[Lldb-commits] [lldb] 5c28d49 - [lldb][NFC] Remove wrong tests in TestCallOverriddenMethod

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 18 12:17:40 PDT 2019


Author: Raphael Isemann
Date: 2019-10-18T19:18:41Z
New Revision: 5c28d49314c7bb84f08c9db3acd5ff64e1c4bc2d
    
URL: https://github.com/llvm/llvm-project/commit/5c28d49314c7bb84f08c9db3acd5ff64e1c4bc2d
DIFF: https://github.com/llvm/llvm-project/commit/5c28d49314c7bb84f08c9db3acd5ff64e1c4bc2d.diff
    
LOG: [lldb][NFC] Remove wrong tests in TestCallOverriddenMethod

We call these tests in the second test function where they are
x-failed on Windows. I forgot to remove the tests from the first
test function (which is not x-failed on Windows) when extracting these
calls into their own test function, so the test is still failing on Windows.

llvm-svn: 375271
    
Added: 
    
    
Modified: 
    lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
    
Removed: 
    
    
    
################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py b/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
index f630aef9e51e..09369f43819c 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
+++ b/lldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
@@ -50,10 +50,6 @@ def test(self):
         # Test calling the base class.
         self.expect("expr realbase.foo()", substrs=["1"])
 
-        # Test with locally constructed instances.
-        self.expect("expr Base().foo()", substrs=["1"])
-        self.expect("expr Derived().foo()", substrs=["2"])
-
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr43707")
     def test_call_on_temporary(self):
         """Test calls to overridden methods in derived classes."""

    
        


More information about the lldb-commits mailing list