[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 17 08:40:20 PDT 2019


clayborg added inline comments.


================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:794
+    SectionSP header_sp = std::make_shared<Section>(
+        module_sp, this, ~user_id_t(0), ConstString("header"),
+        eSectionTypeOther, m_coff_header_opt.image_base,
----------------
maybe name this "COFF header" or "PECOFF header"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69100/new/

https://reviews.llvm.org/D69100





More information about the lldb-commits mailing list