[Lldb-commits] [PATCH] D69106: MemoryRegion: Print "don't know" permission values as such

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, jingham.
labath added a parent revision: D69105: minidump: Create memory regions from the sections of loaded modules.

The permissions in a memory region have ternary states (yes, no, don't
know), but the memory region command only prints in binary, treating
"don't know" as "yes", which is particularly confusing as for instance
the unwinder will treat an unknown value as "no".

This patch makes is so that we distinguish all three states when
printing the values, using "?" to indicate the lack of information. It
is implemented via a special argument to the format provider for the
OptionalBool enumeration.


https://reviews.llvm.org/D69106

Files:
  include/lldb/Target/MemoryRegionInfo.h
  source/Commands/CommandObjectMemory.cpp
  source/Target/MemoryRegionInfo.cpp
  test/Shell/Minidump/memory-region-from-module.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69106.225410.patch
Type: text/x-patch
Size: 4839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191017/8aa3a06d/attachment.bin>