[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

Wed Oct 16 11:24:19 PDT 2019

wallace marked an inline comment as done.
wallace added inline comments.

================
Comment at: lldb/source/Host/linux/Host.cpp:220-222
+  if (process_info.GetNameAsStringRef().empty() &&
+      !process_info.GetArg0().empty()) {
+    process_info.SetBundleID(process_info.GetArg0());
----------------
labath wrote:
> How sure are we that the app processes are the only ones which have the exe link unreadable? Will that be true on all phones or just the recent ones with all the selinux stuff?
> 
> I was hoping that there is some more reliable way of fetching this information, but there doesn't seem to be anything except [[ https://developer.android.com/reference/android/app/ActivityManager.RunningAppProcessInfo.html | ActivityManager.RunningAppProcessInfo ]], which I don't know if it can be accessed from lldb, either host- or device-side.
> 
> @danalbert, any ideas here?
Another option I've just discovered is to invoke `pm list packages` to get the list of all apks and if an Arg0 is in that list, then it's a package.
That seems good enough

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68968/new/

https://reviews.llvm.org/D68968