[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

Wed Oct 16 09:50:56 PDT 2019

hhb added a comment.

In D69016#1710466 <https://reviews.llvm.org/D69016#1710466>, @mgorny wrote:

> I'm not sure if I like the usage of `POST_BUILD` stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines.

Agreed. After I move all the things to cmake, it will be a good idea to refactor POST_BUILD to separate targets. And make sure all file dependencies are correct. For now I want to keep the same semantic.

In D69016#1710716 <https://reviews.llvm.org/D69016#1710716>, @labath wrote:

> In D69016#1710380 <https://reviews.llvm.org/D69016#1710380>, @davide wrote:
>
> > What are you trying to accomplish here?
>
>
> I believe the goal is to delete the custom python script completely and rely on cmake to do this instead. Now that we no longer have two build systems to worry about, I think this is a very good idea and it simplifies the code a lot. I believe that at least @JDevlieghere was also in favour of this direction.

Besides that, I want to make sure cross compiling is correct. In the old python script, we only detect the build platform, and make decision based on that. That's obviously wrong for cross compiling...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69016/new/

https://reviews.llvm.org/D69016