[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=<arch>-windows-msvc to clang-cl

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 15 07:30:14 PDT 2019


aleksandr.urakov added a comment.

In D68980#1709327 <https://reviews.llvm.org/D68980#1709327>, @labath wrote:

> @aleksandr.urakov, since you probably know more about windows and these tests than I do, I'd be interested in hearing your thoughts too...


Sorry, I made some changes to the testing infrastructure only occasionally, so I can't say I'm deep into it. It looks like this patch fixes the problem (may be in a tricky way...) and doesn't make the things worse than they are, that's why I think that proceeding with it for now would be not a bad idea. But I have nothing against fixing the root cause :)


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68980/new/

https://reviews.llvm.org/D68980





More information about the lldb-commits mailing list