[Lldb-commits] [lldb] r374803 - Fix test breakage caused by r374424

Lawrence D'Anna via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 14 11:53:27 PDT 2019


Author: lawrence_danna
Date: Mon Oct 14 11:53:27 2019
New Revision: 374803

URL: http://llvm.org/viewvc/llvm-project?rev=374803&view=rev
Log:
Fix test breakage caused by r374424

Summary:
The build directory name is based on the test method name, so having
two test methods with the same name in the same test file is a
problem, even if they're in different test classes.

On linux and darwin this conflict can go unnoticed, but windows
has different filesystem semantics and it will fail when one
process tries to delete files still held open by another.

The problem is fixed just by changing the name of one of the test
methods.

Reviewers: JDevlieghere, jasonmolenda, labath, stella.stamenova

Reviewed By: stella.stamenova

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D68951

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/python_api/interpreter/TestRunCommandInterpreterAPI.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/interpreter/TestRunCommandInterpreterAPI.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/python_api/interpreter/TestRunCommandInterpreterAPI.py?rev=374803&r1=374802&r2=374803&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/python_api/interpreter/TestRunCommandInterpreterAPI.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/python_api/interpreter/TestRunCommandInterpreterAPI.py Mon Oct 14 11:53:27 2019
@@ -30,7 +30,7 @@ class CommandRunInterpreterLegacyAPICase
         self.dbg.SetErrorFileHandle (self.devnull, False)
 
     @add_test_categories(['pyapi'])
-    def test_run_session_with_error_and_quit(self):
+    def test_run_session_with_error_and_quit_legacy(self):
         """Run non-existing and quit command returns appropriate values"""
 
         n_errors, quit_requested, has_crashed = self.dbg.RunCommandInterpreter(




More information about the lldb-commits mailing list