[Lldb-commits] [PATCH] D68918: eliminate virtual methods from PythonDataObjects

Lawrence D'Anna via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Oct 12 15:28:21 PDT 2019


lawrence_danna created this revision.
lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath, zturner.
Herald added a project: LLDB.

This patch eliminates a bunch of boilerplate from 
PythonDataObjects, as well as the use of virtual methods. 
In my opinion it also makes the Reset logic a lot more 
clear and easy to follow.   The price is yet another 
template.   I think it's worth it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68918

Files:
  lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68918.224759.patch
Type: text/x-patch
Size: 24804 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20191012/a3b98a92/attachment-0001.bin>


More information about the lldb-commits mailing list