[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.


================
Comment at: lldb/CMakeLists.txt:228
+    function(create_relative_symlink target dest_file output_dir output_name)
+      get_filename_component(dest_file ${dest_file} ABSOLUTE)
+      get_filename_component(output_dir ${output_dir} ABSOLUTE)
----------------
The problem is that for multi-configuration generators the current configuration cannot be evaluated at the configuring step i.e. you cannot just insert ${CMAKE_CFG_INTDIR} in the `dest_file` path and use it here. The variable should be expanded in the post-build command.


================
Comment at: lldb/CMakeLists.txt:244
+  else()
+    set(LIBLLDB_SYMLINK_DEST "${liblldb_build_dir}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}")
+  endif()
----------------
This command still produces a path without configuration name, Visual Studio failed to execute the post-build step.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68858/new/

https://reviews.llvm.org/D68858