[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Yeah, I think that's the best we can do right now. Could you just drop the gdb_remote_offset from the `GetPtraceOffset`. It can be recovered from the `index` argument, and I don't want people to think that they _have to_ implement the ptrace offset computation via the gdb offset. I mean ideally, I hope the two things will be the same everywhere else, and x86 is just weird, but conceptually, I'd like the individual architectures to be free to compute the ptrace offset any way they like. Also, could you put that into a separate patch, as it functionally independent of this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62931/new/

https://reviews.llvm.org/D62931