[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 10 14:34:10 PDT 2019


shafik added inline comments.


================
Comment at: source/Symbol/ClangASTContext.cpp:9195
+                 GetAsEnumDecl(type->GetFullCompilerType()))
+      enum_decl->dump(s.AsRawOstream());
+    else {
----------------
teemperor wrote:
> shafik wrote:
> > aprantl wrote:
> > > is an EnumDecl not a TagDecl?
> > I don't understand the comment, `TagDecl` is handled above.
> I think Adrian's point is that EnumDecl is a subclass of TagDecl.
This is a good point, this also goes for `CXXRecordDecl` so removed those cases since they are both covered by `TagDecl`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67994/new/

https://reviews.llvm.org/D67994





More information about the lldb-commits mailing list