[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 10 09:36:26 PDT 2019


shafik added inline comments.


================
Comment at: lldb/source/DataFormatters/StringPrinter.cpp:544
   bool is_truncated = false;
   const auto max_size = process_sp->GetTarget().GetMaximumSizeOfStringSummary();
 
----------------
Why not just make this `uint32_t` making this `auto` gains us nothing but now I am left wondering do the types match later on when we use `max_size`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68010/new/

https://reviews.llvm.org/D68010





More information about the lldb-commits mailing list